Resolves #81 - Reduce log levels #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduced all `log.Error*` events to `log.Debug*` in `exporter.go` where an existing internal metric tracks the event.
SuperQ
reviewed
Aug 15, 2017
| @@ -274,7 +274,7 @@ func (b *Exporter) Listen(e <-chan Events) { | |||
| // We don't accept negative values for counters. Incrementing the counter with a negative number | |||
| // will cause the exporter to panic. Instead we will warn and continue to the next event. | |||
| if event.Value() < 0.0 { | |||
| log.Errorf("Counter %q is: '%f' (counter must be non-negative value)", metricName, event.Value()) | |||
| log.Debugf("Counter %q is: '%f' (counter must be non-negative value)", metricName, event.Value()) | |||
There was a problem hiding this comment.
This one doesn't seem to have a metric associated with it. But, I don't think it's that important.
There was a problem hiding this comment.
Let's add such a metric/error counter before reducing the log level though. Silently dropping metrics would be very annoying.
grobie
reviewed
Aug 15, 2017
| @@ -274,7 +274,7 @@ func (b *Exporter) Listen(e <-chan Events) { | |||
| // We don't accept negative values for counters. Incrementing the counter with a negative number | |||
| // will cause the exporter to panic. Instead we will warn and continue to the next event. | |||
| if event.Value() < 0.0 { | |||
| log.Errorf("Counter %q is: '%f' (counter must be non-negative value)", metricName, event.Value()) | |||
| log.Debugf("Counter %q is: '%f' (counter must be non-negative value)", metricName, event.Value()) | |||
There was a problem hiding this comment.
Let's add such a metric/error counter before reducing the log level though. Silently dropping metrics would be very annoying.
* Added internal metric to track `illegal_negative_counter` events
|
@grobie See updated PR branch, added internal metric as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.Error*events tolog.Debug*inexporter.gowherean existing internal metric tracks the event.